alex/sots-re
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

lane DW: the writer is byte-exact on all 43 saves; make the gate honest

Browse source 
Track 0 items 0a and 0b.  The finding has the full account; the two things
that matter for anyone reading the gate afterwards:

gate.sh was taking TAIL's exit code from `ctest ... | tail -15`, so it printed
"GATE ok host-ctest" directly above "2 tests failed out of 59".  The same
masking was on the host build and on the shim cross-build.  All three now
capture the real status and trim the output afterwards.

The corpus-skip check counted every "unset, skipped" line, two of which are not
corpus tests, so it could never reach zero.  It is now scoped to the tests gated
on the corpus, SOTS_DATA_DIR is set so game_design_census actually runs against
it (43 saves, 2728 designs, 0 mismatched -- a test that had been skipping), and
every remaining skip is printed by name so none can be invisible again.
This commit is contained in:
alex 2026-09-09 10:10:40 -04:00
parent 7dcc66bc66
commit 1df4ffb463
2 changed files with 519 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

501
findings/subsystems/writer-byte-exact.md Normal file
View file

File diff suppressed because one or more lines are too long

25
tools/gate.sh
View file

@ -20,6 +20,7 @@ RE="${RE:-$HOME/sots-re}"
CT=111
REMOTE_TREE=/srv/re-lab/build/sots-engine
REMOTE_CORPUS=/srv/re-lab/saves-corpus
REMOTE_DATA=/srv/re-lab/gob-extract # the extracted asset tree; game_design_census needs it
FRESH=0
[ "${1:-}" = "--fresh" ] && FRESH=1
@ -49,15 +50,25 @@ ssh spicy "pct exec $CT -- mkdir -p $REMOTE_CORPUS && tar -C /tmp/sots-corpus -c
NCORPUS=$(ct "ls $REMOTE_CORPUS | grep -c .sav")
echo "GATE info corpus on CT111: $NCORPUS saves"
# 5. host build + tests, WITH the corpus
ct "cd $REMOTE_TREE && cmake -S . -B build-host -DCMAKE_BUILD_TYPE=Release >/dev/null 2>&1 && cmake --build build-host -j8 2>&1 | tail -1"; report host-build $?
ct "cd $REMOTE_TREE/build-host && SOTS_SAVES_DIR=$REMOTE_CORPUS ctest --output-on-failure 2>&1 | tail -15"; report host-ctest $?
# and prove the corpus tests RAN rather than skipped
SKIPPED=$(ct "cd $REMOTE_TREE/build-host && SOTS_SAVES_DIR=$REMOTE_CORPUS ctest -V 2>&1 | grep -c 'unset, skipped'")
# 5. host build + tests, WITH the corpus AND the extracted data tree
#
# `cmd | tail -1` returns TAIL's status, not the command's -- so for a day this
# script printed "GATE ok host-ctest" over a run with two FAILING tests, which is
# rule 1's failure wearing this script's own clothes. Every step below captures
# the real exit code first and only then trims the output.
ct "cd $REMOTE_TREE && cmake -S . -B build-host -DCMAKE_BUILD_TYPE=Release >/tmp/gate-cfg.log 2>&1 && cmake --build build-host -j8 >/tmp/gate-build.log 2>&1; rc=\$?; tail -1 /tmp/gate-build.log; exit \$rc"; report host-build $?
ct "cd $REMOTE_TREE/build-host && SOTS_SAVES_DIR=$REMOTE_CORPUS SOTS_DATA_DIR=$REMOTE_DATA ctest --output-on-failure >/tmp/gate-ctest.log 2>&1; rc=\$?; tail -15 /tmp/gate-ctest.log; exit \$rc"; report host-ctest $?
# and prove the corpus tests RAN rather than skipped. The check is scoped to the
# tests gated on the CORPUS (they name SOTS_SAVES_DIR when they skip); every other
# skip is listed below it by name, because a skip nobody reads is how this started.
SKIPPED=$(ct "cd $REMOTE_TREE/build-host && SOTS_SAVES_DIR=$REMOTE_CORPUS SOTS_DATA_DIR=$REMOTE_DATA ctest -V 2>&1 | grep -c SOTS_SAVES_DIR")
if [ "${SKIPPED:-1}" -ne 0 ]; then echo "GATE FAIL corpus tests skipped ($SKIPPED) -- the gate is hollow"; status=1; else echo "GATE ok corpus tests ran (0 skipped)"; fi
ct "cd $REMOTE_TREE/build-host && SOTS_SAVES_DIR=$REMOTE_CORPUS SOTS_DATA_DIR=$REMOTE_DATA ctest -V 2>&1 | grep skipped" | sed 's/^/GATE info skip: /'
# 6. shim cross-build
ct "cd $REMOTE_TREE && cmake -S . -B build-shim -DCMAKE_TOOLCHAIN_FILE=cmake/toolchain-mingw-i686.cmake -DCMAKE_BUILD_TYPE=Release >/dev/null 2>&1 && cmake --build build-shim -j8 2>&1 | tail -1 && ls -la build-shim/binkw32.dll"; report shim-cross-build $?
# 6. shim cross-build -- same exit-code discipline as step 5. The `ls` at the end
# is a second, independent check (the artefact exists), not the build's verdict:
# without --fresh a DLL from an earlier run would satisfy it on its own.
ct "cd $REMOTE_TREE && cmake -S . -B build-shim -DCMAKE_TOOLCHAIN_FILE=cmake/toolchain-mingw-i686.cmake -DCMAKE_BUILD_TYPE=Release >/tmp/gate-shim-cfg.log 2>&1; rc=\$?; cmake --build build-shim -j8 >/tmp/gate-shim.log 2>&1 || rc=1; tail -1 /tmp/gate-shim.log; ls -la build-shim/binkw32.dll || rc=1; exit \$rc"; report shim-cross-build $?
echo "== gate: $([ $status -eq 0 ] && echo GREEN || echo RED)"
exit $status