alex/flybrain
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

session: take Worker.Acknowledge's bound from the contract, not a local copy

Browse source 
The CONTRACT-01 amendment narrows Worker.Acknowledge ids to the req-<U64> form, which this
crate already read as DomainRequestId. The 1..=16 bound now comes from the contract's
MAX_ACKNOWLEDGE too, so there is one definition of it rather than two.
This commit is contained in:
acamilo 2026-09-22 13:36:42 +00:00
parent ea4935ade2
commit e80df561dd
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
services/flysim/crates/fly-session/src/worker.rs
View file

@ -17,9 +17,6 @@ use crate::dedup::{Admission, CachedReply, OpClass, OperationKey, ResultCache};
// glob keeps the contract's own names in sight instead of restating them. // glob keeps the contract's own names in sight instead of restating them.
use crate::types::*; use crate::types::*;
/// `Worker.Acknowledge` accepts 1..=16 request ids.
pub const MAX_ACKNOWLEDGE_IDS: usize = 16;
/// The build identity a worker reports in Hello. It is not a profile digest. /// The build identity a worker reports in Hello. It is not a profile digest.
pub fn build_digest() -> Digest { pub fn build_digest() -> Digest {
digest_of_bytes(b"fly-session/synthetic-workers-v1") digest_of_bytes(b"fly-session/synthetic-workers-v1")
@ -686,7 +683,7 @@ async fn acknowledge(
) -> DomainResult<Map<String, Value>> { ) -> DomainResult<Map<String, Value>> {
let params: AcknowledgeParams = AcknowledgeParams::from_json(&request.params) let params: AcknowledgeParams = AcknowledgeParams::from_json(&request.params)
.map_err(|e| DomainError::invalid(format!("Worker.Acknowledge: {e}")))?; .map_err(|e| DomainError::invalid(format!("Worker.Acknowledge: {e}")))?;
if params.request_ids.is_empty() || params.request_ids.len() > MAX_ACKNOWLEDGE_IDS { if params.request_ids.is_empty() || params.request_ids.len() > MAX_ACKNOWLEDGE {
return Err(DomainError::invalid("Worker.Acknowledge takes 1..=16 request ids")); return Err(DomainError::invalid("Worker.Acknowledge takes 1..=16 request ids"));
} }
let acknowledged = { let acknowledged = {